New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DST double occurrence. Add test. #144
Conversation
Good news: it does not hang on March 26th anymore Meh news: All of the matches are at 2:30 AM, but on March 26th it is 1:30 AM. Of course 2:30 AM does not exist on that day, but still wondering if it should then run too early (as of now) or rather too late, e.g. 3:30 AM or if that's possible 3:00 AM which is the first valid time after that. On a related note, how does Vixie Cron handle this? In case Vixie Cron skips such days, we should probably consider putting this behind a configurable option.
|
Very valid points! 02:30 -> 01:30 were completely wrong, which was caused by a miscalculation i minitz. Latest commits revert the previous changes(/safeguards), and instead fix the root cause. Now 02:30 is converted to 03:30, which is the exact same timestamp as 02:30 would have been if there had been no DST transition. This is also exactly how Vixie Cron works. Also, 02:00 will be converted to 03:00, which in real life is one minute past 01:59 etc. @egfx-notifications Would be awesome if you could have a look again 👍 |
This is already such a nice fix that I'll release it now 🚀 |
Very nice indeed, thank you! :) |
Proposed fix for #142
Please have a look @egfx-notifications