Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reloads by recreating the channel registry #262

Merged
merged 3 commits into from Jul 12, 2023
Merged

Fix reloads by recreating the channel registry #262

merged 3 commits into from Jul 12, 2023

Conversation

jpenilla
Copy link
Member

@jpenilla jpenilla commented Jul 9, 2023

Currently, this persists API-registered entries. Not sure if that's what we want to do, or if we should have an event for registering channels instead...

We only support registering commands for channels added at startup anyways.

Currently, this persists API-registered entries. Not sure if that's what we want to do, or if we should have an event for registering channels instead...

We only support registering commands for channels added at startup anyways.
@jpenilla jpenilla marked this pull request as ready for review July 9, 2023 23:24
@jpenilla jpenilla merged commit 702f5ad into 2.1 Jul 12, 2023
2 checks passed
@jpenilla jpenilla deleted the fix-reload branch July 12, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant