Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated http methods page #69

Merged
merged 3 commits into from Jun 24, 2021
Merged

updated http methods page #69

merged 3 commits into from Jun 24, 2021

Conversation

Surtt
Copy link
Contributor

@Surtt Surtt commented Jun 15, 2021

No description provided.

@amshkv amshkv self-requested a review June 21, 2021 09:58
Copy link
Contributor

@amshkv amshkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут с row намудрил оч сильно, зато шапка верная
по семантике - когда мы видим роу - мы хотим работать с колонками, а у тебя по сути одна колонка, а значит она не нужна, и row тоже)
если футер везде правим, то тут давай тоже

</nav>
</div>
<div class="row">
<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот это не хорошо, если мы где-то делаем row, то подразумевается что ребенок будет сначала col

Comment on lines 52 to 55
<div class="row">
<h1 class="mt-3 mb-3">Использование HTTP методов для создания RESTful сервисов</h1>
</div>
<div class="row">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и тут та же история, если у нас один ребенок на весь контейнер - нам не нужен row

@amshkv amshkv merged commit 8928710 into Hexlet:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants