Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys. This PR allows to nest ActiveFormModel forms from AR models with STI column.
I have an error trying to use this gem with STI models like that:
Exception:
That's happened because Rails redefines a
.new
method in active_record/inheritance.rb to find a subclass fromattributes
passed toModel.new
. So#initialize
method is not yet called here and we have unpermitted params.Permitting params in
.new
instead of#initialize
fixes this issue. Please tell me if you see any drawbacks with this approach.