Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add harvard-cs50 school #131

Merged
merged 4 commits into from Feb 13, 2023
Merged

add harvard-cs50 school #131

merged 4 commits into from Feb 13, 2023

Conversation

peperopuripuri
Copy link
Contributor

Added school

@ashikov
Copy link
Contributor

ashikov commented Jan 27, 2023

@ayayalice тут билд завалился. Нужно починить

ashikov
ashikov suggested changes Jan 27, 2023
View reviewed changes
data/schools/harvard-cs50.yml Outdated Show resolved Hide resolved
data/schools/harvard-cs50.yml Outdated Show resolved Hide resolved
data/schools/harvard-cs50.yml Outdated Show resolved Hide resolved
@ashikov
Copy link
Contributor

ashikov commented Jan 30, 2023

@ayayalice сборка так и валится)

@emp7yhead
Copy link
Contributor

@ayayalice починишь сборку?

@peperopuripuri
Copy link
Contributor Author

@emp7yhead Да, сори, пришлось отвлечься от проекта, сегодня постараюсь починить, или завтра если что. Уже работаю над этим)

@peperopuripuri
Copy link
Contributor Author

@ashikov Не получается разобраться, почему падает билд, может потому что школа иностранная?
И вывод ошибки, так понимаю оно сравнивает с уже существующими школами и потом выдаёт мне ошибку.
Куда мне следует обратиться за помощью? Или как лучше поступить сейчас?

@ssssank
Copy link
Contributor

ssssank commented Feb 9, 2023

@ayayalice у вас повторяется ключ "links", тесты об этом говорят:

 YAMLException: duplicated mapping key (67:3)

 64 | mobile:
 65 |   exists: true
 66 |   links: "https://www.edx.org/cou ...
 67 |   links: "https://apps.apple.com/ ...

@ssssank ssssank merged commit 7af94f2 into Hexlet:main Feb 13, 2023
@peperopuripuri peperopuripuri deleted the added_school branch February 13, 2023 11:54
fey pushed a commit to fey/hexlet-comparator that referenced this pull request May 5, 2023
@peperopuripuri @fey
add harvard-cs50 school (Hexlet#131)
8926ac0 
* add harvard-cs50 school

* fix error

* fix error

* fix error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashikov ashikov ashikov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peperopuripuri @ashikov @emp7yhead @ssssank