Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавить code coverage #5

Closed
malikin opened this issue Sep 6, 2019 · 8 comments
Closed

Добавить code coverage #5

malikin opened this issue Sep 6, 2019 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@malikin
Copy link
Contributor

malikin commented Sep 6, 2019

Добавить code coverage с выгрузгой в какой-нибудь сервис - https://codeclimate.com/ к примеру, настроить сборку проекта с проверкой порога покрытия, можно установить пока 80% там дальше решим если что.
@malikin malikin added enhancement New feature or request good first issue Good for newcomers labels Sep 6, 2019
@samokisha
Copy link
Contributor

Нужно ли падать при coverage меньше 80%?

@malikin
Copy link
Contributor Author

malikin commented Sep 7, 2019

@samokisha Конечно, в этом и идея, можно примерно как тут сделать - https://stackoverflow.com/a/41892357

@samokisha
Copy link
Contributor

С помощью JaCoCo делаю. Интеграция будет с https://codecov.io/
Нужно зарегистрироваться там через hexlet.
И в Travis CI добавить переменную окружения CODECOV_TOKEN="<UUID>".
UUID будет тут

samokisha added a commit to samokisha/hexlet-correction that referenced this issue Sep 7, 2019
@samokisha
Added code coverage with codecov.io Hexlet#5
4263d85
@malikin
Copy link
Contributor Author

malikin commented Sep 7, 2019

@samokisha Сегодня уточнил @mokevnin что покрытие на codeclimate будет отправляться

@malikin
Copy link
Contributor Author

malikin commented Sep 7, 2019

https://codeclimate.com/github/Hexlet/hexlet-correction

@samokisha
Copy link
Contributor

Готово #12

@samokisha
Copy link
Contributor

samokisha commented Sep 9, 2019 •
edited

@mokevnin необходимо изменить идентификаторы в README.md для бейджей.

[![Maintainability](https://api.codeclimate.com/v1/badges/<BADGE_ID>/maintainability)](https://codeclimate.com/github/Hexlet/hexlet-correction/maintainability)
[![Test Coverage](https://api.codeclimate.com/v1/badges/<BADGE_ID>/test_coverage)](https://codeclimate.com/github/Hexlet/hexlet-correction/test_coverage)

@samokisha
Copy link
Contributor

Также необходимо добавить в Travis CI переменную окружения CC_TEST_REPORTER_ID
ID здесь: https://codeclimate.com/github/Hexlet/hexlet-correction > Repo Settings > Test coverage

malikin pushed a commit that referenced this issue Sep 9, 2019
@samokisha @malikin
Code coverage with codeclimate.com #5 (#12)
dc8c9d6 
Added code coverage for codeclimate.com
samokisha added a commit to samokisha/hexlet-correction that referenced this issue Sep 10, 2019
@samokisha
Replaced badges ID Hexlet#5
f915d96
malikin pushed a commit that referenced this issue Sep 10, 2019
@samokisha @malikin
Replaced badges ID #5
6bfdf0d
@malikin malikin mentioned this issue Sep 10, 2019
Merged
@malikin malikin closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malikin @samokisha