New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing page #113
Add landing page #113
Conversation
@kacetal привет! Глянь, плиз |
<html lang="en"> | ||
|
||
<head> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@5.2.0/dist/css/bootstrap.min.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
надо использовать WebJar как это сделано в других файлах
</div> | ||
</footer> | ||
</div> | ||
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.2.1/dist/js/bootstrap.bundle.min.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webJar
@niyak93rus тут бы поправить пару моментов о которых написал @kacetal |
add bootstrap webjar to landing page and pom.xml, correct link to project's page
pom.xml
Outdated
@@ -154,10 +154,15 @@ | |||
<version>${database-rider.version}</version> | |||
<scope>test</scope> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrap уже есть на линии 69, добавлять его еще раз не надо, может просто версии обновить на более свежую и проверить что ничего не сломалось
pom.xml
Outdated
</dependencies> | ||
|
||
<build> | ||
<plugins> | ||
<plugins> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
убери пробел
<!DOCTYPE html> | ||
<html lang="en"> | ||
|
||
<head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
если я правильно понял, то из папки static нет доступа к шаблонам thymeleaf. то есть тег у меня так просто пустой становится в итоге
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kacetal с этим не получилось, не понимаю, как правильно сделать. если я правильно понял, то из папки static нет доступа к шаблонам thymeleaf. Если я так же копирую, тег у меня пустой становится.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну надо не использовать папку статик
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Клади в шаблоны
</div> | ||
</footer> | ||
</div> | ||
<script src="/webjars/bootstrap/js/bootstrap.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the head
@niyak93rus доделаете? :) |
@ssssank да, конечно, в ближайшие дни займусь 👍 |
move landing.html to templates
перенеси картинки в static |
@niyak93rus тыц. Вроде по мелочи осталось доделать |
move images to static folder
move static one level up
@niyak93rus Спасибо за помощь, я добавил изменений связанных со статическими ресурсами и контроллер для этой страницы. В остальном всё хорошо, можно мержить. |
#111: make landing page