[#272] fix the button "Hexlet Type Reporter" #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kitdim а можно демо? по поводу коммитов: чтобы было опрятнее, желательно отдельные фичи делать в отдельных ветках и чтобы они не наследовались друг от друга, так как твою другую фичу могут не вмержить, а эту захотят, например поэтому полезно делать их независимыми кирпичиками |
kitdim
force-pushed
the
issue-272---fix-button-hexlet-type-reporter
branch
from
37e03ac
to
467da60
Compare
# Conflicts: # src/main/resources/db/changelog/db.changelog-master.xml
|
@fey привет! |
|
А я демку еще не посмотрел :\ Чет не открывается на рендере. По поводу коммитов да. на будущее лучше воздерживаться от мерж коммитов, которые происходят из-за пулла. |
|
Пока смержу, деплой у нас все равно не работает (сломано из-за др ПРа) |
|
да, долго что-то грузит, ща вот так выглядит |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.