fix: add resume presenter, skills_description validation

app/models/resume.rb

@@ -44,6 +44,7 @@ class Resume < ApplicationRecord
   include StateConcern
   extend Enumerize
   extend TagResumePresenter
+  include ResumePresenter
 
   mark_as_outdated :hexlet_url, :awards_description
 
@@ -60,10 +61,10 @@ class Resume < ApplicationRecord
   validates :github_url, presence: true, unless: :draft?
   validates :summary, length: { minimum: 200 }, presence: true, unless: :draft?
   validates :skills_description, length: { maximum: 250 }, presence: true, unless: :draft?
-  validates :skills_description, presence: true, unless: :draft?
   validates :contact_email, presence: true, unless: :draft?
   validates :contact_email, 'valid_email_2/email': true
   validates :contact_phone, phone: true
+  validate :skills_description_valid_format, unless: :draft?
 
   belongs_to :user
   has_many :answers, inverse_of: :resume, dependent: :destroy
@@ -130,6 +131,12 @@ def initialize(attribute = nil)
     super(attrs_with_defaults)
   end
 
+  def skills_description_valid_format
+    return unless skills.size > 10 || skills.any? { |element| element.size > 25 }
+
+    errors.add(:skills_description)
+  end
+
   def to_s
     name
   end

app/presenters/resume_presenter.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module ResumePresenter
+  def skills
+    skills_description&.split("\n") || []
+  end
+end

app/views/web/resumes/_information.html.slim

@@ -56,7 +56,7 @@ hr.my-auto
       == markdown2html @resume.skills_description_old
     - else
       .row
-        - @resume.skills_description.split("\n")[0..9].each_slice(5) do |skills_slice|
+        - @resume.skills.each_slice(5) do |skills_slice|
           .col-6
             - skills_slice.each do |skill|
               li = skill[0..24]

config/locales/en.activerecord.yml

@@ -145,6 +145,8 @@ en:
       models:
         resume:
           attributes:
+            skills_description:
+              invalid: is not in the correct format
             contact_email:
               invalid: is not in the correct format
             contact_phone:

config/locales/ru.activerecord.yml

@@ -161,10 +161,12 @@ ru:
       models:
         resume:
           attributes:
+            skills_description:
+              invalid: имеют не верный формат
             contact_email:
               invalid: имеет не верный формат
             contact_phone:
-              invalid: имеет неверное формат
+              invalid: имеет не верный формат
         resume/answer/like:
           attributes:
             user:

db/migrate/20240508043924_update_resume_skill_description.rb

@@ -1,6 +1,6 @@
 class UpdateResumeSkillDescription < ActiveRecord::Migration[7.0]
   def change
     rename_column :resumes, :skills_description, :skills_description_old
-    add_column :resumes, :skills_description, :text, limit: 250
+    add_column :resumes, :skills_description, :text
   end
 end

test/controllers/web/account/resumes_controller_test.rb

@@ -190,4 +190,28 @@ class Web::Account::ResumesControllerTest < ActionDispatch::IntegrationTest
     resume = Resume.find_by(name: attrs[:name])
     assert { !resume }
   end
+
+  test '#create fail with invalid skills_description format' do
+    attrs = FactoryBot.attributes_for :resume
+    attrs[:skills_description] = "Too_many_skills\n" * 15
+
+    params = {
+      publish: true,
+      resume: attrs
+    }
+
+    post(account_resumes_path, params:)
+    assert_response :unprocessable_entity
+
+    resume = Resume.find_by(name: attrs[:name])
+    assert { !resume }
+
+    attrs[:skills_description] = 'Invalid_skill_lenght' * 2
+
+    post(account_resumes_path, params:)
+    assert_response :unprocessable_entity
+
+    resume = Resume.find_by(name: attrs[:name])
+    assert { !resume }
+  end
 end