New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pdf download to resume #182
Conversation
app/views/web/resumes/pdfs/base.slim
Outdated
.col-12 | ||
h1.text-center.display-4.mb-2= @user | ||
h2.text-center.lead= resource_resume | ||
.d-flex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
должно быть колонкой, иначе выпадает по отступам
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
дальше такие же ситуации по col\row
app/views/web/resumes/pdfs/base.slim
Outdated
h2.my-4.mr-3= t('.basic') | ||
hr.my-auto.w-100 | ||
|
||
.row.mb-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
row в row
второй как бы должен лежать в col
или вынести его по разметке выше
иначе лублирование отступов
app/views/web/resumes/pdfs/base.slim
Outdated
|
||
- if @resume_works.any? | ||
.d-flex | ||
h2.my-4.mr-3= t('.work') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачем отступ справа?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по всему документу расползлось
app/views/web/resumes/pdfs/base.slim
Outdated
= link_to resource_resume.github_url, resource_resume.github_url, target: '_blank' | ||
|
||
- if @resume_works.any? | ||
.d-flex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
учитывая что внутри два блочных элемента на 100%, может флекс и не нужен?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
опять же это встречается несколько раз по документу
app/views/web/resumes/pdfs/base.slim
Outdated
hr.my-auto.w-100 | ||
|
||
.row.mb-3 | ||
.col-sm-9.hexlet-cv-content.lead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hexlet-cv-content
это что за класс по всему проекту, который не грепается?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кажется осталось приложить новый скрин для пдф
@NikitaNaumenko сделай, пожалуйста, ребейз и новый скрин |
фигасе, уж год прошел) |
3d5270f
to
c96484f
Compare
#123
Добавил возможность выгрузки резюме в PDF и лайв предпросмотр, дизайн резюме пока отстойный нужна рука сильного дизайнера @amshkv я выбираю тебя 🤗