Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flash message #485

Merged
merged 2 commits into from Feb 28, 2023
Merged

fix flash message #485

merged 2 commits into from Feb 28, 2023

Conversation

usernaimandrey
Copy link
Contributor

No description provided.

@@ -1,5 +1,9 @@
ru:
devise:
correct_errors: "Пожалуйста исправте ошибки:"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

опечатка

failure:
user:
banned: "Вы были забанены"
not_found_in_database: Нет пользователя с такой почтой
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

с точки зрения безопасности не очень верно такое сообщать, потому что могут начать брутфорсить. Можно также указать, что пас/логин неверный

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На сколько я помню Devise дает 20-30 попыток, а потом лочит аккаунт)

failure:
user:
banned: "Вы были забанены"
not_found_in_database: Нет пользователя с такой почтой
invalid: Не правельный логин или пароль.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

опечатка. Проверь текст по какому-нибудь сервису.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправил)

@fey fey merged commit 9f6153a into Hexlet:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants