add make comand #500
Merged
add make comand #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fey
reviewed
Mar 25, 2023
| docker-compose run --rm app npm install --force | ||
|
|
||
| compose-install-bundle: | ||
| docker-compose run --rm app bundle install --jobs $(shell nproc) |
There was a problem hiding this comment.
@usernaimandrey кажется появляется много однотиных команд.
Можно сделать одну команду тиа docker-compose-run и запускать её, передавая в переменную команду, которую нужно выполнить. :)
There was a problem hiding this comment.
Можно все сервисные команды вынести в отделный Make file, как это сделанно на КБ make-compose-app, хотя можно и так, толко надо в голове команду и флаг держать ;)
There was a problem hiding this comment.
можно так и так.
У тебя внешняя команда останется такая же, будет типа
docker-compose-run:
docker-compose run --rm app $(C)
compose-app-setup:
make docker-compose-run C="make setup"
типа так.
There was a problem hiding this comment.
да так прикольно
There was a problem hiding this comment.
извиняюсь я там не туда тыкнул, нечайно ишю закрыл, но все поправил)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.