racke task find lost career student #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralder
reviewed
Jul 7, 2023
| @@ -0,0 +1,32 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| namespace :n8n_sender do | |||
There was a problem hiding this comment.
неймспейс странный - n8n здесь же просто инструмен-посредник
ralder
reviewed
Jul 7, 2023
|
|
||
| namespace :n8n_sender do | ||
| desc 'This is task find lost student in career track' | ||
| task find_lost_student: :environment do |
There was a problem hiding this comment.
я бы назвал чтото типа notify_about_lost_students
ralder
reviewed
Jul 7, 2023
| last_activity_at: member.career_step_members.active.last.created_at | ||
| } | ||
| end | ||
| response = Net::HTTP.post uri, payload.to_json, header |
There was a problem hiding this comment.
в идеале сделать бы апи класс для n8n куда все это низкоуровневые вызовы положить
ralder
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.