Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user removing #740

Merged
merged 2 commits into from
Apr 11, 2024
Merged

add user removing #740

merged 2 commits into from
Apr 11, 2024

Conversation

chrtkv
Copy link
Contributor

@chrtkv chrtkv commented Apr 11, 2024

No description provided.

@chrtkv chrtkv requested a review from amshkv April 11, 2024 12:18
@chrtkv chrtkv self-assigned this Apr 11, 2024
app/models/user.rb Outdated Show resolved Hide resolved
@amshkv
Copy link
Contributor

amshkv commented Apr 11, 2024

@corsicanec82 посмотри пожалуйста код
кажется что сохранять removed_at не нужно, мы это лучше сделаем через pappertrail?

и еще - тут используется система как на code-basics через модель и переходы между стейтами
пока не понимаю насколько это лучше\хуже работы через usersevice

@amshkv
Copy link
Contributor

amshkv commented Apr 11, 2024

еще кажется не хватает логики что show удаленного пользователя открывается без проблем
думаю её лучше не показывать совсем или редиректить

@chrtkv chrtkv force-pushed the add_user_removing_posibility branch 3 times, most recently from 7b2c796 to 9d8bb51 Compare April 11, 2024 15:38
@chrtkv chrtkv force-pushed the add_user_removing_posibility branch from 9d8bb51 to d556788 Compare April 11, 2024 16:02
@chrtkv chrtkv changed the title add user removing (wip) add user removing Apr 11, 2024
@chrtkv chrtkv marked this pull request as ready for review April 11, 2024 16:18
@amshkv amshkv merged commit 5146bf5 into main Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants