impove 'make shell' to shell_plus extension using #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lapsed_header Hexler Hexlet#207 fix link on collapsed header
|
@yuriy-kormin видимо забыл обновить poetry.lock, поэтому CI падает. Воспользуйся командой |
|
@emp7yhead обновил poetry. lock |
emp7yhead
suggested changes
Jan 20, 2023
Comment on lines
+16
to
+18
| <a id="card-header-link" href="{{ repo.get_absolute_url }}" | ||
| onclick="window.open(this.attributes.getNamedItem('href').value, '_self')" | ||
| data-bs-toggle="collapse"><b>{{ repo.full_name }}</b></a> |
There was a problem hiding this comment.
А как это связано с установкой shell_plus?
Comment on lines
+3
to
+5
| {% block head_scripts %} | ||
|
|
||
| {% endblock %} |
There was a problem hiding this comment.
Это же не влияет на устанавливаемый shell_plus
|
прошу прощения - не тот коммит) сейчас поправлю |
yuriy-kormin
added a commit
to yuriy-kormin/hexlet-friends
that referenced
this pull request
Jan 20, 2023
updating .lock-file
emp7yhead
added a commit
that referenced
this pull request
Jan 24, 2023
improve 'make shell' to shell_plus extension using #226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В курсе Хекслета django-orm рекомендуется использовать shell_plus в качестве консоли django. преимущества - модели и пользовательские классы загружаются автоматом при старте консоли
В пулл-реквест включены установка плагина и поправленный Makefile