Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/source links #302

Merged
merged 3 commits into from May 31, 2020
Merged

Feature/source links #302

merged 3 commits into from May 31, 2020

Conversation

Laserroy
Copy link
Contributor

Не знаю где лучше размещать ссылку в шаблоне:
https://newexercisetest.herokuapp.com/exercises/1

Добавил файл с ссылками 'exercise-links.yml' -> добавил миграцию на доп.колонку -> изменил сидер.
Так нормально делать?

@codecov-commenter
Copy link

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #302   +/-   ##
=========================================
  Coverage     74.26%   74.26%           
  Complexity      120      120           
=========================================
  Files            46       46           
  Lines           509      509           
=========================================
  Hits            378      378           
  Misses          131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1223a92...05e9913. Read the comment docs.

@fey fey merged commit e339271 into Hexlet:master May 31, 2020
@fey
Copy link
Collaborator

fey commented May 31, 2020

Блин. Миграция на заполнение колонки отдельно не сработает.
Получается выкрутас.
Я тогда поправлю, лучше из файлика ссылку будем брать, это удобней, чем из бд

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants