Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #626 Add link to Hexlet profile #636

Merged
merged 11 commits into from Dec 14, 2020
Merged

Conversation

Malcom1986
Copy link
Contributor

Не знаю, как с bootstrap правильно сделать вывод ссылки на странице пользователя

https://malcom-hexlet-sicp.herokuapp.com/ru

@codecov-io
Copy link

Codecov Report

Merging #636 (8300cad) into master (35371c8) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #636      +/-   ##
============================================
+ Coverage     81.52%   81.66%   +0.14%     
  Complexity      133      133              
============================================
  Files            52       52              
  Lines           644      649       +5     
============================================
+ Hits            525      530       +5     
  Misses          119      119              
Impacted Files Coverage Δ Complexity Δ
app/User.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
...pp/Http/Controllers/Settings/ProfileController.php 96.29% <100.00%> (+0.84%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f922cf...8300cad. Read the comment docs.

@fey
Copy link
Collaborator

fey commented Dec 10, 2020

Выглядит нормально,
https://malcom-hexlet-sicp.herokuapp.com/img/hexlet_logo.png - картинка не подгружается. Можешь ее стащить и закинуть в ассеты?

@Malcom1986
Copy link
Contributor Author

Да, сделаю

@fey
Copy link
Collaborator

fey commented Dec 11, 2020

Можешь сделать в одну строку?

@Malcom1986
Copy link
Contributor Author

Попробую

@Malcom1986
Copy link
Contributor Author

profile

@Malcom1986
Copy link
Contributor Author

@fey fey merged commit 64c7311 into Hexlet:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants