Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#653] Подключил bootstrap 5 и выполнил замену классов для нескольких элементов #656

Closed
wants to merge 9 commits into from

Conversation

Liocha
Copy link

@Liocha Liocha commented Jan 28, 2021

No description provided.

@Liocha
Copy link
Author

Liocha commented Jan 30, 2021

Посмотреть работу можно тут https://sicp-hexlet.herokuapp.com/

@fey fey requested a review from amshkv January 30, 2021 14:57
@amshkv amshkv marked this pull request as ready for review February 1, 2021 13:32
@Liocha Liocha force-pushed the bootstrap_dependency_update branch from a761955 to 7da8010 Compare February 1, 2021 15:00
@Liocha Liocha force-pushed the bootstrap_dependency_update branch from 7da8010 to 9d637b4 Compare February 1, 2021 15:26
@amshkv
Copy link

amshkv commented Feb 4, 2021

image - как минимум сломана кнопка по цвету
image - какой-то странынй отступ, про подчеркивание ссылок пока тоже не очень понятно
image - форма входа абсолютно другая, как и регистрации

@codecov-io
Copy link

codecov-io commented Feb 13, 2021

Codecov Report

Merging #656 (b2ac615) into master (db1036a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #656   +/-   ##
=========================================
  Coverage     82.03%   82.03%           
  Complexity      165      165           
=========================================
  Files            54       54           
  Lines           679      679           
=========================================
  Hits            557      557           
  Misses          122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1036a...b2ac615. Read the comment docs.

@Liocha
Copy link
Author

Liocha commented Feb 14, 2021

image - как минимум сломана кнопка по цвету

Насколько я понял, в Bootstrap v5 изменили миксин, теперь цвет текста на кнопке определяется по-другому. Так как в _variables.scss задан кастомный

$blue: #3490dc; 

для него будет цвет текста черный.

The button-variant() mixin now accepts 3 optional color parameters, for each button state, to override the color provided by color-contrast(). By default, these parameters will find which color provides more contrast against the button state’s background color with color-contrast().

@Liocha
Copy link
Author

Liocha commented Feb 14, 2021

image - какой-то странынй отступ, про подчеркивание ссылок пока тоже не очень понятно

Отступ убрал. Подчеркивание ссылок так как в Bootstrap v5

Links are underlined by default (not just on hover), unless they’re part of specific components.

Не совсем понятно как лучше сделать. Самый простой вариант убрать подчеркивание совсем, даже при hover.

@Liocha
Copy link
Author

Liocha commented Feb 14, 2021

image - форма входа абсолютно другая, как и регистрации

Проблема только в ширине кнопки? Удалил .btn-block и добавил .w-100

Dropped .btn-block in favor of CSS grid utility classes. Instead of applying .btn-block to individual buttons, a group of buttons now get wrapped in a parent .d-grid class and can use .gap-* utilities for spacing. For individual “block buttons”, add .w-100.

@fey
Copy link
Collaborator

fey commented Jun 26, 2021

Обновил тикетос #653 будет переезжать постранично.

@fey fey closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants