Редактор с проверкой упражнения #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fey
force-pushed
the
feat/solution-checker
branch
from
9c479ce
to
8821335
Compare
fey
force-pushed
the
feat/solution-checker
branch
3 times, most recently
from
45eb24f
to
ee5ee5d
Compare
fey
force-pushed
the
feat/solution-checker
branch
from
ee5ee5d
to
279ce55
Compare
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
============================================
- Coverage 83.59% 78.93% -4.66%
- Complexity 174 192 +18
============================================
Files 56 58 +2
Lines 707 788 +81
============================================
+ Hits 591 622 +31
- Misses 116 166 +50
Continue to review full report at Codecov.
|
amshkv
reviewed
Mar 13, 2021
| </a> | ||
| </li> | ||
| </ul> | ||
| <div class="tab-content card-body" id="pills-tabContent"> |
There was a problem hiding this comment.
странное ID
используется и kebab-case и camel-case
мб есть линтер на вьюхи чтобы такое ловить? (чтобы в одном стиле было)
There was a problem hiding this comment.
линтера на вьюху нету, фиксанул айдишник
amshkv
reviewed
Mar 13, 2021
Comment on lines
26
to
48
| {{ BsForm::open(null, ['wire:submit.prevent' => 'check']) }} | ||
| @if(\App\Helpers\ExerciseHelper::exerciseHasTests($exercise)) | ||
| @switch($state) | ||
| @case(\App\Http\Livewire\ExerciseEditor::STATE_SUCCESS) | ||
| <div class="alert alert-success" role="alert"> | ||
| {{ __('exercise.show.editor.message.success') }} | ||
| </div> | ||
| @break | ||
| @case(\App\Http\Livewire\ExerciseEditor::STATE_FAILED) | ||
| <div class="alert alert-warning" role="alert"> | ||
| {{ __('exercise.show.editor.message.failed') }} | ||
| </div> | ||
| @break | ||
| @endswitch | ||
| @else | ||
| @if ($state === \App\Http\Livewire\ExerciseEditor::STATE_SUCCESS) | ||
| <div class="alert alert-success" role="alert"> | ||
| {{ __('exercise.show.editor.message.success') }} ({{ __('exercise.show.editor.auth.required') }}) | ||
| </div> | ||
| @else | ||
| <div class="alert alert-success" role="alert"> | ||
| {{ __('exercise.show.editor.message.has_not_tests') }} | ||
| </div> |
There was a problem hiding this comment.
меня вот этот набор алертов несколько смущает, это нельзя сделать как-то аккуратнее?
типа хелпера, который будет возвращать тип алерта и текст внутри? чтобы во вьюхе от такой сложной логики уйти?
amshkv
approved these changes
Mar 13, 2021
fey
force-pushed
the
feat/solution-checker
branch
3 times, most recently
from
897cfbc
to
05c77d1
Compare
fey
force-pushed
the
feat/solution-checker
branch
2 times, most recently
from
124830a
to
feae5bb
Compare
fey
force-pushed
the
feat/solution-checker
branch
from
feae5bb
to
a7cde54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ограничения:
Можно загружать решение несколько раз со страницы (нет дизейбла после загрузки)
https://fey-sicp.herokuapp.com/exercises/3