Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP pages #425

Merged
merged 2 commits into from Sep 29, 2022
Merged

AMP pages #425

merged 2 commits into from Sep 29, 2022

Conversation

seth2810
Copy link
Contributor

@seth2810 seth2810 commented Aug 23, 2022

No description provided.

@seth2810 seth2810 mentioned this pull request Aug 23, 2022
@seth2810 seth2810 force-pushed the next-amp branch 7 times, most recently from ab28874 to b9824be Compare August 26, 2022 13:27
@dzencot
Copy link
Collaborator

dzencot commented Sep 6, 2022

ПР актуальный? Исправишь конфликты?

@seth2810
Copy link
Contributor Author

seth2810 commented Sep 6, 2022

ПР актуальный? Исправишь конфликты?

@dzencot да-да, это WIP - work in progress

@seth2810 seth2810 marked this pull request as draft September 8, 2022 14:07
@seth2810 seth2810 force-pushed the next-amp branch 3 times, most recently from 5b681b4 to 113d72d Compare September 16, 2022 15:07
@seth2810 seth2810 marked this pull request as ready for review September 16, 2022 15:07
@seth2810
Copy link
Contributor Author

@dzencot review 🙏🏾

@seth2810 seth2810 force-pushed the next-amp branch 2 times, most recently from f763aa3 to 2b981a2 Compare September 18, 2022 08:10
@seth2810 seth2810 changed the title [WIP] nextjs post amp page AMP pages Sep 18, 2022
@seth2810
Copy link
Contributor Author

@fey @ashikov review 🙏

@fey fey requested a review from dzencot September 20, 2022 14:18
@fey
Copy link
Collaborator

fey commented Sep 20, 2022

Думаю тут стоит добавить демку

@seth2810
Copy link
Contributor Author

Думаю тут стоит добавить демку

Так я использую для этого наш "тестовый" стенд на heroku. Тыкайте, играйтесь:

https://hexletguides.herokuapp.com/amp/learning/
https://hexletguides.herokuapp.com/ru/amp/error-tracking/

@seth2810
Copy link
Contributor Author

@fey удалось глянуть?

@fey
Copy link
Collaborator

fey commented Sep 23, 2022

@seth2810 конфликтики

@seth2810
Copy link
Contributor Author

@seth2810 конфликтики

стабилизировал

@seth2810
Copy link
Contributor Author

@ashikov
Copy link
Contributor

ashikov commented Sep 27, 2022

@dzencot ты апрувил. Сливаю?

@seth2810
Copy link
Contributor Author

@ashikov сливай :goberserk:

@ashikov ashikov merged commit 72e9f32 into Hexlet:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants