Add tab #11
Merged
Add tab #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Я пока закомментировал тесты, так как они пока вообще не писались |
fey
reviewed
Jul 16, 2021
.github/workflows/nodejs.yml
Outdated
| - name: Run test | ||
| run: make test | ||
| # - name: Run test | ||
| # run: make test |
There was a problem hiding this comment.
actions падает, так как тестов пока нет
There was a problem hiding this comment.
Давай простенький тест сделаем.
frontstall
suggested changes
Jul 20, 2021
src/components/TabItem.jsx
Outdated
| const TabItem = ({ id, name }) => { | ||
| const currentTabId = useSelector((state) => state.tabs.currentTabId); | ||
| const dispatch = useDispatch(); | ||
| const isActive = id === currentTabId ? true : null; |
There was a problem hiding this comment.
давай сделаем false вместо null
src/components/Tabs.jsx
Outdated
| {tabsList.map(({ id, name }) => ( | ||
| <TabItem key={id} id={id} name={name} /> | ||
| ))} | ||
| <Button variant="light" onClick={addNewTab}>+</Button> |
There was a problem hiding this comment.
ну пожалуйста :)
атрибут title сделает кнопку доступной - посмотри, как ведёт себя кнопка + в хроме, например
src/slices/tabs.js
Outdated
| @@ -0,0 +1,33 @@ | |||
| /* eslint-disable no-param-reassign */ | |||
| import { createSlice } from '@reduxjs/toolkit'; | |||
| import _ from 'lodash'; | |||
There was a problem hiding this comment.
frontstall
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9