Fix quicklisp-clhs-ensure-symbolic-link #12
Conversation
This removes the warning if what should be recognized as a symlink exists as a folder on Windows. (Issue #10)
|
I assume there should be some way to recognize symlinks on Windows and fix this neatly, but I was not able to find it. |
|
Thank you! I'll process this later, as I'm really desperate to finally finish and release my 10 new libraries, so dealing with this right now would be a really big context switch for me. This has already dragged on for way too long, and I fear I'm headed for a huge depression if I don't finish this soon. Beyond that, in the long term what I want to is make a spiritual sequel to the CLHS based on dpANS3, something similar to https://clos-mop.hexstreamsoft.com/, I just need to build some more infrastructure first. Since that version will incorporate offline support through a service worker, this CLHS ASDF wrapper is mostly headed for deprecation and it's hard for me to motivate myself to keep investing in it. I'll try integrating the pending changes in Q1 2021 at the latest. Could be earlier, but no promises... edit: I think a better commit title would be better, though, "Update clhs-use-local.el" is pretty generic. |
|
Bon courage alors! Your projects look interesting, I'll have to look at them more closely. |
chuchana
changed the title
The original version of `quicklisp-clhs-ensure-symbolic-link` was missing a trailing slash in the resolved symlink it compared to the desired destination. I added the function `quicklisp-clhs-symlink-resolved` to make it more readable.
|
I don't know why I assumed the symlinks were not recognized on Windows. I now checked, saw that they worked, and found the actual problem. |
chuchana
changed the title
|
Actually what I just committed is wrong, I'll fix that. |
The original version of `quicklisp-clhs-ensure-symbolic-link` was missing a trailing slash in the resolved symlink it compared to the desired destination. I added the function `quicklisp-clhs-symlink-resolved` to make it more readable.
|
I see 3 commits, I think ideally you would rebase this into 1 commit... |
|
I tried and eventually succeeded locally, but couldn't push it github. Then I deleted and recreated my repository on github. Now it has just that one commit, but is not connected to this pull request. Should I close this one and create a new one? If so, to the branch |
|
I think you just needed to use the Now you would have to create a new pull request against the same branch, yes. |
|
Ok |
This removes the warning if what should be recognized as a symlink exists as a folder on Windows. (Issue #10)