Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip asking github for latest hash, if we're requesting a specific hash #211

Merged
merged 1 commit into from Aug 2, 2016

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Jun 30, 2016

Means one less call to curl in that scenario

@popcornmix
Copy link
Collaborator

I wonder if any of this is needed.
I believe rpi-update and rpi-update HEAD both get the latest code, so just the line
FW_REV=${FW_REV:-HEAD} may be all that is needed.

@lurch
Copy link
Contributor Author

lurch commented Jun 30, 2016

just the line FW_REV=${FW_REV:-HEAD} may be all that is needed.

That would end up writing HEAD into /boot/.firmware_revision though, which probably isn't very useful ;-)

(and I guess https://github.com/Hexxeh/rpi-update/blob/master/rpi-update#L355 means that you'd then only be able to rpi-update just the once?)

@popcornmix
Copy link
Collaborator

Yes, good point.

@Ruffio
Copy link

Ruffio commented Aug 2, 2016

@lurch what is the conclusion on this one? That the RP is ready to merge, that it should be dismissed or?

@lurch
Copy link
Contributor Author

lurch commented Aug 2, 2016

IMHO this patch is still worth merging. I've just rebased it on top of the latest version of master.

@popcornmix popcornmix merged commit a05ee80 into Hexxeh:master Aug 2, 2016
@lurch lurch deleted the patch-1 branch August 2, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants