Raspbmc should not update by default

[samnazarko]

Raspbmc handles firmware and kernel by itself, but being a Debian system, it is not uncommon for users to run rpi-update on it.

I have changed default behaviour to not do this on Raspbmc installations, but added a variable (UPDATE_RASPBMC), which when set to 1, will override this.

[popcornmix]

Rather than adding a rasbmc specific option, I'd prefer a generic option (that may be useful for Arch or Fedora).
How about renaming to:
RPI_UPDATE_UNSUPPORTED

[Hexxeh]

Happy for this to go in under a more generic name as dom has suggested.

[samnazarko]

I will add a generic setting and a method of detection for Raspbmc systems, but I cannot help with Raspbian as I am unsure of what criteria would be appropriate to check if the system is compatible.

[popcornmix]

Not quite sure why there are two variables now.
I was imagining exactly the change you first submitted, but with UPDATE_RASPBMC replaced with RPI_UPDATE_UNSUPPORTED (and the text of the failure message changed).

raspbmc should export RPI_UPDATE_UNSUPPORTED=1. raspian would leave it unset.
Arch/Fedora would set it or leave it as they see fit.

[samnazarko]

I added two variables, where one, UNSUPPORTED can be set in a series of different evaluative statements:

i.e.

test -f /scripts/upd_hist/build_info && UNSUPPORTED = 1
test -f /usr/bin/pacman && UNSUPPORTED = 1

Then, at the end, if the UNSUPPORTED flag is true, and the user has not specified to force an update, we exit with a message.

I can change it if you wish, but I am unsure if Arch / Fedora will implement those changes. It would be much easier to use my example above.

[popcornmix]

I imagined that rpi-update wouldn't try to identify the distribution.
The distribution would (unconditionally) set RPI_UPDATE_UNSUPPORTED if they didn't want rpi-update to be run.

[samnazarko]

Works for me.

[popcornmix]

You've still got the UNSUPPORTED variable which doesn't see to do anything. Can't that be removed?