Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding type declarations and corresponding npm script #9

Merged
merged 1 commit into from
Jun 8, 2023
Merged

feat: adding type declarations and corresponding npm script #9

merged 1 commit into from
Jun 8, 2023

Conversation

Cadienvan
Copy link
Contributor

I hope it is helpful and appreciated, as it solves what's asked in #7 .
I targeted es2015 because minimatch uses private identifiers, so it's the bare minimum for it to work.

@jelveh
Copy link
Contributor

jelveh commented Jun 7, 2023

Hello @Cadienvan,

Thank you very much for this very important PR! Your contribution is truly appreciated.
We're going to review the pull request and update you soon.

@jelveh jelveh merged commit ab96f2a into HeyPuter:main Jun 8, 2023
@jelveh
Copy link
Contributor

jelveh commented Jun 8, 2023

Merged! Thank you very much for your contribution. This was a very useful addition to KV.js

@jelveh jelveh mentioned this pull request Jun 8, 2023
@Cadienvan
Copy link
Contributor Author

That's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants