id -> of and editor accessibility

Heydon · Dec 29, 2018 · 6b12e4a · 6b12e4a
1 parent 05c6702
commit 6b12e4a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/editor.html b/editor.html
@@ -1,3 +1,5 @@
+<!DOCTYPE html>
+<html lang="en">
 <meta charset="utf-8">
 <meta name="viewport" content="width=device-width, initial-scale=1.0">
 <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -49,7 +51,7 @@
 <body>
   <div class="wrapper">
     <form role="form">
-      <textarea id="editor">
+      <textarea id="editor" aria-label="code editor">
 <!-- 
 see the component docs: 
 https://github.com/Heydon/bruck#components 

diff --git a/js/components/Clone.js b/js/components/Clone.js
@@ -3,12 +3,12 @@
 export default class Clone extends HTMLElement {
   constructor() {
     super();
-    this.id = this.getAttribute('of');
-    if (!this.id) {
+    this.of = this.getAttribute('of');
+    if (!this.of) {
       console.error('Each <c-lone> element must have an `of` attribute pointing to a <template> id.');
       return;
     }
-    this.template = document.getElementById(this.id);
+    this.template = document.getElementById(this.of);
     Promise.all([
       customElements.whenDefined('g-rid'),
       customElements.whenDefined('s-tack')