Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update faraday version to 1.0.1 #40

Conversation

antodoms
Copy link

@antodoms antodoms commented Oct 1, 2020

Description

  • updated faraday to latest version

@antodoms antodoms closed this Oct 1, 2020
@harrylewis
Copy link
Member

Hey @antodoms! 👋

Thanks for the contribution. It's good to know faraday has been updated, and it would be great to get this change into the gem. Would you consider re-opening this?

@antodoms antodoms reopened this Oct 3, 2020
@TylerRick
Copy link

TylerRick commented Feb 28, 2023

https://github.com/lostisland/faraday is at 2.7.4 now. Why is this gem locked to faraday < 1.0 and can we update to the latest?

And no, this is not actually causing me problems or blocking me at the moment, but it did surprise me when I switched to this gem from a much older beanstream gem and saw the faraday version change drastically:

    -faraday (2.7.4)
    +faraday (0.17.6)

@harrylewis
Copy link
Member

Hey @TylerRick, thanks for the comment 👋🏻

The reason for locking it at that version was because that the main use case for the gem maintainers requires a lower version of faraday. We didn't want to mislead folks into thinking it had been tested and evaluated with higher versions of faraday.

That being said, I don't any issues with relaxing those version constraints, as long as it is made clear in the README that it has only been tested with lower versions of faraday.

If you wish, you can also provide more insight into how it is functioning on higher versions of faraday. Let me know what you think!

@TylerRick
Copy link

As a general practice, it seems like gems should remain compatible with current/recent versions of their dependencies. Otherwise, if you have 2 gems in your project that depend on faraday, and one of those is locked to faraday 0.17.6, and the other requires at least 2.x, then you have a problem...

This is currently only a hypothetical problem for us, since this is the only gem in our project that uses faraday, but just wanted to chime in with a "we should update someday"... 😄

@harrylewis
Copy link
Member

@TylerRick the day has come! We have updated the faraday requirements to a more modern version.

@harrylewis harrylewis closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants