Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use JS_UpdateStackTop #50

Closed
andrieshiemstra opened this issue Jun 28, 2021 · 4 comments
Closed

use JS_UpdateStackTop #50

andrieshiemstra opened this issue Jun 28, 2021 · 4 comments
Milestone

Comments

@andrieshiemstra
Copy link
Member

after init of the runtime use this set the correct stack top

and maybe set the max size as a large number by default

@andrieshiemstra
Copy link
Member Author

i've been unable to get this to work in a sensible way, will try later for a 0.6.1 release

andrieshiemstra added a commit that referenced this issue Nov 30, 2021
flipping ugly impl (i need to prevent resetting stack top when using do_with nested)
but i'm curious if this works for you
@andrieshiemstra andrieshiemstra modified the milestones: 0.6.1, 0.7 Dec 22, 2021
@andrieshiemstra
Copy link
Member Author

Hi @SreeniIO

i'd like to work towards a 0.7 release and like to know if the above code fixes your issue with max_stack_size not working

it seems to work for me

@SreeniIO
Copy link
Contributor

SreeniIO commented Jan 6, 2022

I guess it works fine, haven't seen any issue so far related to stack size.

@andrieshiemstra
Copy link
Member Author

this tickets was created to reenable the option to set a max stack size as discussed here

#48 (comment)

i did some preliminary testing and it seems to function properly now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants