Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and ignore old events #48

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Cleanup and ignore old events #48

merged 5 commits into from
Jun 25, 2024

Conversation

153957
Copy link
Member

@153957 153957 commented Jun 24, 2024

No description provided.

Incorrectly ignoring writer_app.py.
In current deployment the other files are also not in repo directory.
Some data provided to the writer will have been uploaded to Nikhef,
where the wsgi app was not as strict with marking events as suspect.
@153957 153957 requested a review from davidfokkema June 24, 2024 14:30
Copy link
Member

@davidfokkema davidfokkema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice cleanup and indeed, older than 2020 should go.

Update tests to use pathlib and already existing config ini.
Add directory for logs.
Improve importing and configuring of wsgi and writer applications.
@153957 153957 merged commit b09e4ed into master Jun 25, 2024
3 checks passed
@153957 153957 deleted the cleanup branch June 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants