Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip erroneous configuration messages #183

Merged
merged 2 commits into from Jun 28, 2017

Conversation

tomkooij
Copy link
Member

If number of messages > MAX_NUMBER_OF_CONFIGS (100): Treat configs as erroneous and skip. (Leave in raw datastore, but do not import new configs)

This should prevent #182 from happening again.

If number of configuration messages > MAX_NUMBER_OF_CONFIGS (100). Treat
configs as erroneous and skip. (Leave in raw datastore, but do not import new
configs)
@153957
Copy link
Member

153957 commented Apr 23, 2017

Good idea.
We do need to make these kinds of errors in the hisparc-update more loud. Now they can go by unnoticed. Easiest might be to also print error logs to stderr, which can be mailed to us when they occur in the cron job..

@tomkooij
Copy link
Member Author

Yes, I like that:

  • Use stdout as logger stream in hisparc-update.py, redirect that to /var/log/hisparc.log in the cron job.
  • add extra logger at loglevel error to stderr. cron should mail that.

@tomkooij tomkooij mentioned this pull request Apr 26, 2017
5 tasks
@153957 153957 self-requested a review June 28, 2017 07:20
@153957 153957 merged commit 6b668a9 into HiSPARC:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants