Try using QUOTE function instead of replace hack

HicServices · Aug 29, 2022 · 0db0c40 · 0db0c40
1 parent 0570bb9
commit 0db0c40
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml
@@ -42,7 +42,9 @@ jobs:
 
     - name: ccache
       uses: hendrikmuhs/ccache-action@v1.2
+      if: false
     - name: Prep for MySQL bisection
+      if: false
       run: |
         export PATH=/usr/lib/ccache:$PATH
         git clone https://github.com/mysql/mysql-server.git
@@ -53,20 +55,21 @@ jobs:
         make -sj`nproc`
     - name: Setup upterm session
       uses: lhotari/action-upterm@v1
-      if: contains(github.ref,'refs/tags/')
+      if: false
 
     - name: MySQL
       run: |
         sed -i'' -e 's|</TestDatabases>|<TestDatabase><DatabaseType>PostgreSql</DatabaseType><ConnectionString>User ID=postgres;Password=pgpass4291;Host=127.0.0.1;Port=5432</ConnectionString></TestDatabase></TestDatabases>|' Tests/FAnsiTests/TestDatabases.xml
         sed -i'' -e 's/Pwd=;SslMode=None/Pwd=root;AllowPublicKeyRetrieval=true/' Tests/FAnsiTests/TestDatabases.xml
+        sudo systemctl start mysql.service
 
-        sudo curl -o /etc/apt/trusted.gpg.d/mariadb_release_signing_key.asc 'https://mariadb.org/mariadb_release_signing_key.asc'
-        sudo sh -c "echo 'deb https://mirrors.xtom.com/mariadb/repo/10.9/ubuntu focal main' >>/etc/apt/sources.list"
-        sudo apt-get update
-        sudo apt-get install mariadb-server
-        sudo mysql -uroot <<EOM
-        ALTER USER 'root'@'localhost' IDENTIFIED BY 'root';
-        EOM
+        #sudo curl -o /etc/apt/trusted.gpg.d/mariadb_release_signing_key.asc 'https://mariadb.org/mariadb_release_signing_key.asc'
+        #sudo sh -c "echo 'deb https://mirrors.xtom.com/mariadb/repo/10.9/ubuntu focal main' >>/etc/apt/sources.list"
+        #sudo apt-get update
+        #sudo apt-get install mariadb-server
+        #sudo mysql -uroot <<EOM
+        #ALTER USER 'root'@'localhost' IDENTIFIED BY 'root';
+        #EOM
     - name: Test
       if: contains(github.ref,'refs/tags/')
       run: dotnet --logger "console;verbosity=minimal" --nologo

diff --git a/Implementations/FAnsi.Implementations.MySql/Aggregation/MySqlAggregateHelper.cs b/Implementations/FAnsi.Implementations.MySql/Aggregation/MySqlAggregateHelper.cs
@@ -288,7 +288,7 @@ order by
 SELECT
   GROUP_CONCAT(
     CONCAT(
-      '{0}(case when {1} = \'', REPLACE(pivotValues.piv,'\'','\\\''), '\' then {2} else null end) AS `', pivotValues.piv,'`'
+      '{0}(case when {1} = ', QUOTE(pivotValues.piv), ' then {2} else null end) AS `', pivotValues.piv,'`'
     )
   ) INTO @columnsSelectCases
 FROM