Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ViewLogs with eds #1453

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Fix ViewLogs with eds #1453

merged 1 commit into from
Oct 3, 2022

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Oct 3, 2022 •
edited
Loading

Fixes #1447

Changes behaviour of SelectOne when DisallowInput is true and AllowAutoSelect is true (and theres only one object). In this case the sole value is returned.

If passed a logging server but no filter then ViewLogs will deafult to showing the DataLoadRun table.

@tznind tznind requested a review from jas88 October 3, 2022 11:21
@tznind tznind merged commit a6fdb65 into develop Oct 3, 2022
@tznind tznind deleted the view-logs branch October 3, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jas88 jas88 jas88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ViewLogs on CLI does not check IsInteractive
2 participants
@tznind @jas88