-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin loading adjustment (RDMP-130) #1716
Conversation
…ing any old nupkg file
@@ -241,8 +242,7 @@ | |||
/// <param name="notifier"></param> | |||
private static void LoadMEF(ICatalogueRepository catalogueRepository, ICheckNotifier notifier) | |||
{ | |||
foreach (var (name, body) in Directory.EnumerateFiles(AppDomain.CurrentDomain.BaseDirectory, "*.nupkg") | |||
.SelectMany(LoadModuleAssembly.GetContents)) | |||
foreach (var (name, body) in LoadModuleAssembly.PluginFiles().SelectMany(LoadModuleAssembly.GetContents)) |
Check notice
Code scanning / CodeQL
Missed 'using' opportunity Note
disposed
finally block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to revisit this for a long-term view on how to handle plugins (perhaps with the future MSI work) but this will handle the immediate problem we say Early January
Use rdmpplugins.txt to control plugin loading instead of blindly loading any old nupkg file, workaround for autoupdater leaving old plugin files (and other debris which we should address better at some point!) lying around.
Falls back on previous behaviour (load *.nupkg) if no rdmpplugins.txt file exists.