Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rdmp 119 data load deltas #1726

Merged
merged 81 commits into from
Feb 5, 2024
Merged

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Jan 18, 2024

No description provided.

@JFriel JFriel marked this pull request as ready for review January 22, 2024 11:39
@JFriel JFriel requested a review from jas88 January 23, 2024 09:01
Copy link
Member

@jas88 jas88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, just a few details left to check

Documentation/DataLoadEngine/RemoteAttachers.md Outdated Show resolved Hide resolved
Documentation/DataLoadEngine/RemoteAttachers.md Outdated Show resolved Hide resolved
Documentation/DataLoadEngine/RemoteAttachers.md Outdated Show resolved Hide resolved
Documentation/DataLoadEngine/RemoteAttachers.md Outdated Show resolved Hide resolved
Rdmp.Core/CommandLine/Runners/DleRunner.cs Outdated Show resolved Hide resolved
Rdmp.Core/Curation/Data/DataLoad/LoadMetadata.cs Outdated Show resolved Hide resolved
Rdmp.Core/Rdmp.Core.csproj Outdated Show resolved Hide resolved
}
}

private static Scenario[] Scenarios = {

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Scenarios' can be 'readonly'.
Scenario.MissingPreLoadDiscardedColumn,
Scenario.MissingPreLoadDiscardedColumnButSelectStar
};
private static AttacherHistoricalDurations[] Durations = {

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Durations' can be 'readonly'.
@jas88 jas88 merged commit ef0afe8 into develop Feb 5, 2024
7 checks passed
@jas88 jas88 deleted the feature/RDMP-119-data-load-deltas branch February 5, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants