-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rdmp 119 data load deltas #1726
Conversation
…ature/RDMP-119-data-load-deltas
erge branch 'develop' of https://github.com/HicServices/RDMP into feature/RDMP-119-data-load-deltas
…into feature/RDMP-119-data-load-deltas
Rdmp.Core.Tests/DataLoad/Engine/Integration/RemoteDatabaseAttacherTests.cs
Fixed
Show resolved
Hide resolved
Rdmp.Core.Tests/DataLoad/Engine/Integration/RemoteDatabaseAttacherTests.cs
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, just a few details left to check
Rdmp.Core.Tests/DataLoad/Engine/Integration/RemoteAttacherTests.cs
Outdated
Show resolved
Hide resolved
Rdmp.Core/Databases/CatalogueDatabase/up/078_AddLastLoadTimeToLoadMetadata.sql
Outdated
Show resolved
Hide resolved
…ature/RDMP-119-data-load-deltas
…m/HicServices/RDMP into feature/RDMP-119-data-load-deltas
} | ||
} | ||
|
||
private static Scenario[] Scenarios = { |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
Scenario.MissingPreLoadDiscardedColumn, | ||
Scenario.MissingPreLoadDiscardedColumnButSelectStar | ||
}; | ||
private static AttacherHistoricalDurations[] Durations = { |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
No description provided.