Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/rdmp-100 Allow project specific extraction updates #1733

Merged

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Jan 24, 2024

Jira Ticket
This change relaxes the extraction category restrictions for project specific extraction identifiers.
Project Specific catalogues can now use all extraction categories expect core

To Test

  • Within RDMP, create a project specific catalogue with some columns
  • Right click a column within the catalogue viewer and change the extraction category
  • Should be able to change 'Project Specific' -> All categories expect 'Core'
  • Attempting to change to core will warn the user that the category will remain 'Project Specific'

@JFriel JFriel requested a review from a team January 24, 2024 10:25
@JFriel JFriel marked this pull request as ready for review January 24, 2024 10:25
using NSubstitute.Extensions;
using Rdmp.Core.DataExport.Data;
using Rdmp.Core.Curation.Data.Aggregation;
using static Org.BouncyCastle.Math.EC.ECCurve;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another stray Bouncycastle inclusion?

@JFriel JFriel requested a review from jas88 February 7, 2024 08:18
@bpeacock001 bpeacock001 merged commit 1f7c0b3 into develop Feb 13, 2024
7 checks passed
@bpeacock001 bpeacock001 deleted the task/RDMP-100-allow-project-specific-extraction-updates branch February 13, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants