Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

Uncomplete theme #19

Closed
ivanpu opened this issue Oct 17, 2013 · 6 comments
Closed

Uncomplete theme #19

ivanpu opened this issue Oct 17, 2013 · 6 comments

Comments

@ivanpu
Copy link
Collaborator

ivanpu commented Oct 17, 2013

The theme still looks uncomplete also on Linux:
rs-theme
I can understand the title bar, but is it possible to color everything else, without changing OS theme?
Also note the button hover effect.

@HikariKnight
Copy link
Member

that did not happen on my tests :o
i can avoid changing the theme on the tab bars but the hover part of the buttons i do not think i can change that, i could look into trying "flat buttons" or using actual bitmaps as buttons, thanks for the info ivan

@ghost ghost assigned HikariKnight Oct 17, 2013
@ivanpu
Copy link
Collaborator Author

ivanpu commented Oct 17, 2013

You welcome.
I have no experience with theming in wxWidgets -- had no need to do it in my programs.
So hopefully, you'll figure it out.
Until then, I think to untheme the tabs is good option.

And the rest looks good!
(Except not themed buttons in Add-Ons tab :P)

@HikariKnight
Copy link
Member

i left those unthemed to get feedback on the theme in general first (plus im planning on using wxHtmlWindow to display addons in the future)

also i have managed to find a workaround maybe by making the client use a custom gtkrc file because i cannot avoid the hover part of the buttons :x
i would need you online to help me test this though

@HikariKnight
Copy link
Member

@ivanpu
could you email me your gtkrc for your theme? or the theme itself so i can do local tests?

@HikariKnight
Copy link
Member

Just mentioning that it looks like I cannot fix this as the main theme overrides the button hover style. Sadly I am no genious with gtk themes so I will try looking around a bit more

@HikariKnight
Copy link
Member

decided i wont be able to fix this as it would require a "special" gtk theme for the launcher itself where we have to make sure it works with the common gtk engines that are in use. However after this issue came up, i changed the theme so it does not affect the tabs but only objects inside them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants