【課題】AmazonのURL変換 & CSV出力 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaichiSaito
reviewed
May 7, 2022
lib/convert_url.rb
Outdated
| ] | ||
|
|
||
| decoded_url = url_array.map do |url| | ||
| item_data = url[25..-1].gsub!('/', ',') |
There was a problem hiding this comment.
25文字というのはちょいと脆いですね。ドメイン変わった瞬間動かなくなるので。
There was a problem hiding this comment.
確かに変化に対応できない実装ですね。
修正しました 694c0d1
DaichiSaito
reviewed
May 7, 2022
.byebug_history
Outdated
Comment on lines
1
to
10
| exit | ||
| du | ||
| n | ||
| next | ||
| item_data | ||
| exit | ||
| item | ||
| n | ||
| exit | ||
| item_data |
There was a problem hiding this comment.
また追加されちゃってます。
プルリクをあげる際に毎回Files changedを確認する癖をつけた方が良いですね。
There was a problem hiding this comment.
失礼しました。上げる前に毎回確認するようにいたします
0e97172
DaichiSaito
reviewed
May 7, 2022
lib/convert_url.rb
Outdated
Comment on lines
18
to
23
| amazon_csv = CSV.generate do |csv| | ||
| decoded_url.each do |du| | ||
| csv << %w[商品ID 商品名] | ||
| csv << [du[3], du[5]] | ||
| end | ||
| end |
There was a problem hiding this comment.
generateではなくopen に修正しました。
e86acb6
DaichiSaito
reviewed
May 7, 2022
lib/convert_url.rb
Outdated
Comment on lines
12
to
16
| decoded_url = url_array.map do |url| | ||
| item_data = url.split('/') | ||
| item_data[3] = CGI.unescape((item_data[3]).to_s) | ||
| item_data | ||
| end |
There was a problem hiding this comment.
個人的には多次元配列は極力使いたくないですね。わかりづらくなるので。
やるなら
[
{ id: "xxx", url: "xxx" },
{ id: "xxx", url: "xxx" },
{ id: "xxx", url: "xxx" },
]
のようなidとurlをキーに持つハッシュの配列にした方が自然かなと思います。
There was a problem hiding this comment.
多次元配列は強力使わないようにします。
今回は、ハッシュの配列で対応いたしました。
e86acb6
DaichiSaito
reviewed
May 8, 2022
Comment on lines
14
to
18
| item_data = { | ||
| id: url_data[5], | ||
| url: CGI.unescape((url_data[3]).to_s) | ||
| } | ||
| item_data |
There was a problem hiding this comment.
ここも細かいですが、わざわざitem_dataという変数に格納する必要はないですね。
{
id: url_data[5],
url: CGI.unescape((url_data[3]).to_s)
}だけで良いと思いますよ。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
「AmazonのURL変換 & CSV出力」の課題が終了しました。
レビューをお願いいたします。