Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Pass at Multiline Strings #43

Merged
merged 16 commits into from
May 16, 2022
Merged

First Pass at Multiline Strings #43

merged 16 commits into from
May 16, 2022

Commits on May 14, 2022

  1. Add several tests for multiline strings 

    Currently they only cover the "folded" style of strings, and I'm sure
there are edge cases I haven't covered yet, but it's a start.
    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    6be785b View commit details
    Browse the repository at this point in the history

  2. First pass at folded multiline strings

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b538bcf View commit details
    Browse the repository at this point in the history

  3. Add more test cases and fix additional content

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    5ceb1a9 View commit details
    Browse the repository at this point in the history

  4. Line endings for Escape.kt

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    7ad9ae7 View commit details
    Browse the repository at this point in the history

  5. Use countSkipIf instead of creating new method

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b189207 View commit details
    Browse the repository at this point in the history

  6. Extract method for taking remainder of line

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    1b6f725 View commit details
    Browse the repository at this point in the history

  7. Rename method to be specific to folded strings

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    700d87b View commit details
    Browse the repository at this point in the history

  8. Add test and support for prepended newlines

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    441e7b7 View commit details
    Browse the repository at this point in the history

  9. Add test and fix for only leading newlines

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b5c1ac2 View commit details
    Browse the repository at this point in the history

  10. Add another empty string test

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    48fd9c4 View commit details
    Browse the repository at this point in the history

  11. Extract some functions to make code more readable

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    2641318 View commit details
    Browse the repository at this point in the history

  12. More refactoring to make code easier to understand

    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    65a6c73 View commit details
    Browse the repository at this point in the history

  13. Add tests for literal multiline strings 

    Also fix a bug I found thanks to a mistake in a test. Still looking for
more test cases to throw at it to make sure it works as expected in all
scenarios
    @floralvikings
    floralvikings committed May 14, 2022
    Configuration menu
    Copy the full SHA
    1f1b009 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Fix literal tests, add literal support

    @floralvikings
    floralvikings committed May 15, 2022
    Configuration menu
    Copy the full SHA
    df6b8a1 View commit details
    Browse the repository at this point in the history

  2. Declare TestStringData within MultilineStringTest

    @floralvikings
    floralvikings committed May 15, 2022
    Configuration menu
    Copy the full SHA
    531d708 View commit details
    Browse the repository at this point in the history

  3. Code cleanup, PR feedback, minor bug fix

    @floralvikings
    floralvikings committed May 15, 2022
    Configuration menu
    Copy the full SHA
    7f017cf View commit details
    Browse the repository at this point in the history