Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Behaves ideally #659

Closed

Conversation

Aayushraj22
Copy link

Related Issue

fix: #503

Description

Fixes pagination behaviour on category change, now on change category pagination pageNo always point to 1(one) at start irrespective of which pageNo it was in the previous category.

Now pagination behaves very smooth means pagination will display only 5 pages at a time but if totalPage < 5 then is display only that amount of pages.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

paginationFix.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

can we use state manager instead of localstorage for category linking.

@Aayushraj22 Aayushraj22 changed the title Fix/pagination behaviour [fix]: Pagination Behaves ideally Jun 4, 2024
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devlabs ❌ Failed (Inspect) Jun 4, 2024 6:32pm

Copy link

vercel bot commented Jun 4, 2024

@Aayushraj22 is attempting to deploy a commit to the himanshunarware's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Aayushraj22
Copy link
Author

Aayushraj22 commented Jun 8, 2024

can you share the logs why it fails deployment because locally it runs fine and nothing seems wrong to me.
or could you provide some way where we can discuss on it, like discord channel or something.

@Aayushraj22 Aayushraj22 changed the title [fix]: Pagination Behaves ideally Pagination Behaves ideally Jun 8, 2024
@panwar8279
Copy link
Collaborator

There is some deployment error.

@panwar8279 panwar8279 closed this Jun 12, 2024
@Aayushraj22
Copy link
Author

@panwar8279 can you provide me more information why it fails deployment everytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Pagination interfere between categories.
2 participants