to typescript #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Himenon
commented
Sep 17, 2018
Himenon
commented
- JS to Typescript
Himenon
commented
Sep 20, 2018
| @@ -0,0 +1,157 @@ | |||
| import * as dot from 'dot-prop' | |||
| import * as glamor from 'glamor/server' | |||
There was a problem hiding this comment.
どうやら、npmに上がっているpackageは型定義ファイルが含まれていない模様。
https://github.com/threepointone/glamor/blob/master/server.d.ts
tsconfig.json
Outdated
| "forceConsistentCasingInFileNames": true, | ||
| "noImplicitReturns": true, | ||
| "noImplicitThis": true, | ||
| "noImplicitAny": false, |
There was a problem hiding this comment.
本当はtrueにしたいが、こいつに含まれている
https://github.com/threepointone/glamor
Himenon
commented
Sep 21, 2018
src/Markdown.ts
Outdated
|
|
||
| private applyProps = (scope: any) => { | ||
| const { options = {} } = this.props | ||
| // @ts-ignore |
src/createComponents.ts
Outdated
| 'styled-components': ({ name, type, style, props, system = [] }: StyledOptions, lib: any) => { | ||
| const tag = lib[type] || type | ||
| const funcs = getFunctions(system) | ||
| // @ts-ignore |
src/jsx.ts
Outdated
| @@ -0,0 +1,24 @@ | |||
| // @ts-ignore | |||
| import * as transformJSX from 'babel-plugin-transform-react-jsx' | |||
src/jsx.ts
Outdated
| // @ts-ignore | ||
| import * as transformJSX from 'babel-plugin-transform-react-jsx' | ||
| // @ts-ignore | ||
| import * as babel from 'babel-standalone' |
src/render.ts
Outdated
| const renderPage = (scope: any, opts: Options) => (page: any) => { | ||
| const library = opts.library | ||
| // @ts-ignore | ||
| const Provider = themeProviders[library] || themeProviders.default |
src/render.ts
Outdated
| // @ts-ignore | ||
| const Provider = themeProviders[library] || themeProviders.default | ||
| // @ts-ignore | ||
| const getCSS = cssCreators[library] || cssCreators.default |
src/render.ts
Outdated
| .get(scope, 'theme.fonts', []) | ||
| .map((font: string) => webfont.getLinkTag(font)) | ||
| // @ts-ignore | ||
| .filter(tag => !!tag) |
Himenon
force-pushed
the
refactor/typescript
branch
from
1d2527b
to
f38aec0
Compare
|
次、rename |
Himenon
force-pushed
the
refactor/typescript
branch
from
87e81db
to
719d97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.