update(code): リファクタ・コード整理

Himenon · Nov 10, 2018 · cb9fd87 · cb9fd87
1 parent a45e41f
commit cb9fd87
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 167 deletions.
diff --git a/src/react-markdown/__tests__/markdown.test.tsx b/src/react-markdown/__tests__/markdown.test.tsx
@@ -1,4 +1,5 @@
 import * as React from 'react';
+import * as ReactDOM from 'react-dom/server';
 import * as renderer from 'react-test-renderer';
 import { Heading1, Heading1Props } from '../heading1';
 import { defaultProps, Markdown, MarkdownProps } from '../markdown';
@@ -19,15 +20,23 @@ describe('MarkdownComponent', () => {
     expect(jsonValue).toEqual({ type: 'h1', props: {}, children: ['sample text'] });
   });
 
+  test('props.textを設定しない', () => {
+    const props: MarkdownProps = {
+      h1: {},
+      scope: { Title: (props1: Heading1Props) => <Heading1 {...props1} /> },
+    };
+    const result = ReactDOM.renderToStaticMarkup(<Markdown {...props} />);
+    expect(result).toEqual('<div></div>');
+  });
+
   test('Rendering Value', () => {
     const props: MarkdownProps = {
-      text: '<h1>Hello Gen</h1>',
+      text: '<h1>Hello React Markdown</h1>',
       h1: {},
       scope: { Title: (props1: Heading1Props) => <Heading1 {...props1} /> },
     };
-    const result = renderer.create(<Markdown {...props} />);
-    const jsonValue = result.toJSON();
-    expect(jsonValue).toEqual({ type: 'div', props: {}, children: null });
+    const result = ReactDOM.renderToStaticMarkup(<Markdown {...props} />);
+    expect(result).not.toEqual('<div><h1>Hello React Markdown</h1></div>');
   });
 
   test('Rendering Value no scope', () => {

diff --git a/src/remark-react-latest/__tests__/main.test.tsx b/src/remark-react-latest/__tests__/main.test.tsx
diff --git a/src/remark-react-latest/index.ts b/src/remark-react-latest/index.ts
diff --git a/src/remark-react-latest/sample.tsx b/src/remark-react-latest/sample.tsx
diff --git a/src/remark-react/__tests__/options.test.tsx b/src/remark-react/__tests__/options.test.tsx
@@ -29,4 +29,19 @@ describe('remarkReactComponents', () => {
       children: ['foo'],
     });
   });
+
+  test('a', () => {
+    const result = renderer.create(
+      Options.remarkReactComponents.a({
+        href: 'http://example.com',
+        children: 'foo',
+      }),
+    );
+    const jsonValue = result.toJSON();
+    expect(jsonValue).toEqual({
+      type: 'h1',
+      props: {},
+      children: ['foo'],
+    });
+  });
 });