-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): create initial template #1
Conversation
|
||
function App() { | ||
return ( | ||
<Suspense fallback={<RouteLoading />}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to have also ErrorBoundary component at least at the top level.
error-boundary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why, but we don't have it in the latest projects, I'll check it and we can discuss on the team meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you effort. It looks great!
I left some comments for some the parts may be improved from my point of view.
I'll update imports to only lazy import "Help" route |
feat(icon): update hipo icon and add favicon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
feat: update eslint package versions
Description
Forked from official typescript template, added some of our common components and configurations.
Includes:
Notes
How to test on local?
You can clone the repo, checkout to this branch, then go up one direction, and run:
This should work just like default cra template.
To be discussed
These are not included atm, I suggest we add them (in a next PR), we can discuss:
useAsyncProcess
and use GitHub API (it's free) to fetch and show Hipo Org. informationYou can write if you have any additional suggestions