Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing default from_number #15

Open
ozandogrultan opened this issue Oct 31, 2019 · 3 comments
Open

Consider providing default from_number #15

ozandogrultan opened this issue Oct 31, 2019 · 3 comments

Comments

@ozandogrultan
Copy link

ozandogrultan commented Oct 31, 2019

https://github.com/Hipo/django-sms-toolkit/blob/master/django_sms_toolkit/tasks.py#L11

We should consider getting from_number directly from DJANGO_SMS_TOOLKIT_SETTINGS which will let the user not being obligated to pass from_number=settings.DJANGO_SMS_TOOLKIT_SETTINGS["DEFAULT_FROM_NUMBER"] every time task is called.

Pointed by: @fergalwalsh

@yigitguler
Copy link
Member

I think from_number can be customizable. We can make it optional.

@alicertel
Copy link
Contributor

Providing from_number is optional if you are using TwilioMessageMixin. Don't u use the mixin?

@alicertel
Copy link
Contributor

It can also be optional in send_sms task similar to the method in mixin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants