Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow placing ref declarations before lifecycle hooks #3

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

bedirhankaradogan
Copy link
Contributor

Notes

  • This change has been made due to this conversation.

@@ -140,6 +140,7 @@ module.exports = {
"order": [
"type-annotations",
"static-methods",
"instance-variables",
"lifecycle",
"everything-else",
"rendering"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the order for rendering group?

"rendering": [
            "render",
            "/^render.+$/"
          ]

@edizcelik
Copy link

    "react/sort-comp": [
      2,
      {
        order: [
          "static-methods",
          "instance-variables",
          "getters",
          "setters",
          "lifecycle",
          "everything-else",
          "rendering"
        ],
        groups: {
          rendering: ["render", "/^render.+$/"]
        }
      }
    ],

@bedirhankaradogan This should be the latest configuration for this rule.

@bedirhankaradogan bedirhankaradogan merged commit 132d48b into master Aug 21, 2019
@jamcry jamcry deleted the fix/declaration-order-updates branch February 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants