Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JacobiKey public in PolynomialsUtils #322

Closed
MaximeJo opened this issue Mar 20, 2024 · 1 comment · Fixed by #323
Closed

Make JacobiKey public in PolynomialsUtils #322

MaximeJo opened this issue Mar 20, 2024 · 1 comment · Fixed by #323
Assignees
@MaximeJo
Milestone
3.1

Comments

@MaximeJo
Copy link
Contributor

JacobiKey is a private inner class of PolynomialsUtils class.

I suggest to make it public or extract it in a dedicated class, so that it can be used elsewhere.

See for example this usage in Orekit where the class had to be duplicated.
@maisonobe
Copy link
Contributor

A dedicated class seems appropriate.

MaximeJo added a commit to MaximeJo/hipparchus that referenced this issue Mar 20, 2024
@MaximeJo
Extracted JacobiKey from PolynomialsUtils.
a157609 
Fixes Hipparchus-Math#322
@MaximeJo MaximeJo mentioned this issue Mar 20, 2024
Merged
maisonobe added a commit that referenced this issue Mar 20, 2024
@maisonobe
Merge pull request #323 from MaximeJo/issue-322
49de2c9 
#322: Extracted JacobiKey from PolynomialsUtils.
@Serrof Serrof added this to the 3.1 milestone Mar 20, 2024
maisonobe added a commit that referenced this issue Mar 21, 2024
@maisonobe
Allow variable arguments for building PolynomialFunction.
cc610e9 
Fixes #322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximeJo MaximeJo

Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

#322: Extracted JacobiKey from PolynomialsUtils. MaximeJo/hipparchus
3 participants
@maisonobe @Serrof @MaximeJo