Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Ash Walker flavor text modification #11119

Merged
merged 1 commit into from Apr 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2019

Original PR: tgstation/tgstation#43463

馃啈
tweak: Ash Walkers have received a modification to their flavor text clarifying their intent to remain on lavaland and protect their nest.
/:cl:

Why:
Because Ash Walkers breaking into mining and rushing off to the station is boring, obnoxious, and only ever fun for the people doing it, usually at the expense of permanently ending several other people's rounds. Ghost roles are not your free respawn to reinvolve yourself in the round, and for a ghost role that is given pseudo antag status this is doubly true. The way I chose to phrase this isn't set in stone, I wanted something that has at least a little bit of flavor to it instead of blatantly just writing "DON'T GO TO THE STATION".

Tweak was just a guess on my part, I don't really feel like this is balance because it mostly concerns how ash walkers are administrated, wherein the primary rule is "Obey your flavor text." If someone bitches and moans about my choice in CL tags I'll change it.

Ash Walker flavor text modification
@Jujumatic
Copy link
Contributor

Think this will actually stop people bumrushing to the station? LUL

@Jujumatic
Copy link
Contributor

christ, original pr has 7 upvotes and like 24 downvotes

@subject217
Copy link
Contributor

It's a rules thing mate, there's no reason to merge it as is on Hippie because you presumably treat ghost roles differently in your rules. Use your brain, you've got one somewhere in there.

@Jujumatic
Copy link
Contributor

actually we do need to merge it in order to keep up to date with our upstream as we need to have as few diffs as possible in order to reliably merge any tg code.

but we can just modularise out the string.

get dunked 馃ぃ

@subject217
Copy link
Contributor

I'm well aware of how keeping it up to date works, hence "as is". Feel very good about yourself though Jujumatic, Hippie Station definitely appreciates you cleaning up all the shit we make for you, and I definitely find it entertaining to watch you complain about things you don't understand.

@yoyobatty
Copy link
Contributor

Juju quit your shit lad, I don't need you stirring crap between us and other codebases.

@Jujumatic
Copy link
Contributor

You're not really accomplishing anything by stirring up trouble anyway, but if you think you're doing a justice by insulting someone who pointed out votes on a stupid pr, more power to you. Maybe one day you'll actually put in some effort to make a game mechanic that prevents ash walkers from going onto the station since you seem so salty about them raiding the station and killing you. The low pressure lungs come into mind. But yeah go for a low effort lame text change. Seems like you really know what you're talking about when you're completely incapable of doing any proper coding yourself. Go back to your parents and tell them you did good today so they can tuck you back into bed and tell you that you did a good job today and saved the world by beefing with a maintainer by insulting their knowledge of code, whilst you don't even know what code is if it shoved you up the ass.

@optimumtact

This comment was marked as outdated.

@Jujumatic
Copy link
Contributor

馃槩

@Carbonhell
Copy link
Contributor

Noone gives a fuck about the lore text, and it is only indicative, it isn't a rule. No need to modularize this out even.

@Jujumatic
Copy link
Contributor

great!

@Jujumatic Jujumatic merged commit 06304f3 into master Apr 8, 2019
@Jujumatic Jujumatic deleted the upstream-pr-141842625-experimental branch April 8, 2019 10:03
ghost pushed a commit that referenced this pull request Apr 8, 2019
@Lxtoofonea
Copy link
Contributor

please no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants