Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixed a rare custom shuttle docker client crash #5090

Merged
merged 2 commits into from Nov 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2017

Original PR: tgstation/tgstation#33086

Fixed a bug caused by images with high pixel_x and pixel_y values. I am fairly certain this is a BYOND bug.

To reproduce the crash:

  • Use the syndicate shuttle docking computer and move the eye somewhere without placing the landing zone
  • Go to the white ship and place a landing zone directly on top of the invisible syndicate shuttle docker's eye
  • Move the camera to one side until you can barely see the landing zone on the edge of your screen
  • Hit the end camera view button

If one of the landing zone images was over the center of the syndicate shuttle docker eye and if your camera was in a place where you would be able to see the syndicate shuttle docker eye (if it were not invisible to you) but not the turf that it was centered on, your dreamseeker will freeze and you will have to end the program.

Here is the BYOND bug report for what I am fairly certain is causing this: http://www.byond.com/forum/?post=2294466

The same bug is probably also causing #33000

@ghost ghost added the Upstream PR Merged label Nov 27, 2017
@GuyonBroadway GuyonBroadway merged commit c79f882 into master Nov 27, 2017
@JohnGinnane JohnGinnane deleted the upstream-merge-33086 branch December 2, 2017 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants