Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'git2' index management strategy #20

Merged
merged 5 commits into from
Dec 14, 2019
Merged

Added 'git2' index management strategy #20

merged 5 commits into from
Dec 14, 2019

Conversation

Hirevo
Copy link
Owner

@Hirevo Hirevo commented Nov 20, 2019

This PR depends on #18.

This PR introduces a new strategy for managing the crate index named git2.
This strategy makes use of the libgit2 library to interact with the crate index repository.
This allows Alexandrie to operate in environments that doesn't have a git command available from the command line.

The strategy's configuration is similar to the 'disk' one:

[index]
type = "git2"        # required
path = "crate-index" # required

The 'git2' strategy is only available if Alexandrie is compiled with the 'git2' feature enabled.
The reason for this feature-gate is to reduce compilation times in case it isn't used/needed to be available.

Yet to do:

  • fully implement all Indexer trait methods
  • fully document the code (how is it implemented)
  • document the feature (at a high-level, how to use, etc...)

@Hirevo Hirevo added C-enhancement Category: Enhancement P-high Priority: High labels Nov 20, 2019
@Hirevo Hirevo added this to the Core feature-set milestone Nov 20, 2019
@Hirevo Hirevo self-assigned this Nov 20, 2019
@Hirevo Hirevo force-pushed the feature/git2-index branch 2 times, most recently from 07f76ba to 9470b3d Compare November 21, 2019 08:03
@Hirevo Hirevo mentioned this pull request Dec 14, 2019
@Hirevo Hirevo merged commit da34a28 into master Dec 14, 2019
@Hirevo Hirevo deleted the feature/git2-index branch December 14, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement P-high Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant