-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ] Remember scroll height when panel is on the right side #106
Comments
That seems like a reasonable change. Thanks for the good video. If I remember correctly, @pelatx wrote the autohide feature some time ago. Would you be interested to look into this? Otherwise, I'll have a look later. |
Yes @Hirse. I am interested. |
Im glad you guys like it. PS i got one more thing, but thats for @pelatx. Is it possible to add perhaps some sort of delay. Now with the menu on the right side. When i try to scroll sometimes i hit the bar by accident. Than the menu pops open of course. But a delay will also have its downside of course, user need to wait and most people hate waiting :) Custom works has a small half circle showing in the middle. Perhaps something like this? Perhaps i should have made a new post for this :)... |
I like the semicircle idea, but I'm not shure that works correctly on right side of the editor. Due the editor scroll bar. Maybe a short delay can be fine. I could test both and let you know my impressions. But I want to know @Hirse's opinion about this before. |
@pelatx, I agree completely. I wouldn't mind adding another setting for the delay (we can argue about the default value 😉). I'd be very happy if you want to give it a try. |
Okay sweet! I just noticed the update, it works like a charm! This is so much easier to work with now, hope other users find this as handy. Thanks for this quick release, really fast coding there!!! |
Wow was this feature really that simple to add. I only see there is a var declared which essentially is always False. I dont see it being declared True. Seem almost to simple |
Yesterday I tried the semi circle and I was able to confirm that there is interference with the editor's scroll bar. I think it's not a good solution. I'm going to write the delay to see how it works. @Hirse, how would you implement the option for delay? in the preferences menu with an input box directly there? With a modal dialog that opens from an option in the preferences menu? @schroef, yes that has been a very simple solution. Only one variable that saves the scrolled pixels when the outline is going to hide. And then they are read when it's going to show up again. |
Thanks, @pelatx. |
I agree with that. I had misinterpreted your previous comment and I understood that you just wanted to add it to the settings dropdown of the Outline. I have an initial version and I'm going to raise a PR so you can try it. From here, if the feature should be included, we can continue from what you suggest. Regarding the delay, I opted for 0.5 seconds, after trying a bit. |
v1.4.1
osx 10.11.6
I would like to know if it's possible to remember the scroll position when the panel is on the right side. I really like this option and that its closing by itself. The downside is that one needs to tons of scroll because each time the scroll is reset to zero or top.
Could there perhaps be added some variable which check the scroll position so it can be called upon when panel opens again?
See attached, this is what i mean, each time it closes i need to find the prior position. Which is very tedious
![remember-scroll-position](https://user-images.githubusercontent.com/6923008/47193925-4f25e600-d323-11e8-98bc-00355a4590c7.gif)
The text was updated successfully, but these errors were encountered: