fix: account for fn:root bugfix in eXist 6.1.0

Before eXist 6.1.0, eXist’s implementation of the fn:root() function contained a bug that caused it to always return a document node, even when called on an in-memory node whose root node was an element node. This bug was fixed in eXist-db/exist#4402.

The only code in hsg-shell that assumed the buggy behavior was the code that handled the display of concurrent appointments in POCOM data.

After upgrading HSG from 5.1.1 to 6.2.0, this code triggered an error.

modules/pocom-html.xqm

@@ -527,9 +527,9 @@ declare function pocom:format-roles($person) {
             let $sorted-roles :=
                 for $role in $item/*
                 (: delicately construct a new root node containing all of the info needed to reconstruct position description with dept:format-role() :)
-                let $role-node := element {$role/name()} {$role/*}
+                let $role-node := document { element {$role/name()} {$role/*} }
                 return
-                    pocom:format-role($person, $role-node/*[2])
+                    pocom:format-role($person, $role-node/*/*[2])
             return
                 <li>
                     <em>Concurrent Appointments</em>